Max the cutoff for splat penalty much higher #22545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One proposal for JuliaLang#22370
|
Very cool. |
|
OSX build timed out... |
|
Run nanosoldier here? |
|
Let's see if I can do this... @nanosoldier |
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
|
Is this still on the table for julia 1.0. Maybe it's worth trying to more gradually increase each of the three parameters individually in order to investigate their effect on the benchmarks? |
|
doesn't apply anymore (these constants are gone) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One proposal for #22370. I took @vtjnash 's changes, put a nice simple number on them, and also upped the splatting length. Not entirely sure how to argue specifics here.